[HOLD] feat: import keyshares into non empty keyshare storage #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevindeforth
changed the title
Base automatically changed from
kd/import-keyshares-into-empty-keyshare-storage
to
main
October 6, 2025 09:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On hold for now. This will only become relevant once we start work on the backup service for the hard launch. It's not a priority right now.
Resolves #1214
Todo:
A good way to showcase the usefulness of this refactor would be though an integration test, where we have two
KeyshareStorageinstances. One representing the Backup Service, the other representing the MPC node.The
KeyshareStoragerepresenting the backup service will repeatedly import the keyshares from theKeyshareStorageinstance representing the MPC nodes.