Remove unused tokens in compilation test#951
Merged
austinabell merged 1 commit intonear:masterfrom Oct 28, 2022
Merged
Conversation
Contributor
|
Sorry if I'm missing the motivation here, but what is the purpose of changing this within our compilation tests? This shouldn't affect what you're building? Are you suggesting that something within our macros could be changed to allow it to be extended in external libs? |
Contributor
Author
|
The feature proposed in #952 uses tokens passed after the name of |
Contributor
Author
|
Assuming |
Contributor
austinabell
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#[near_bindgen]macro currently ignores tokens after the attribute name, for example#[near_bindgen(this_is_ignored)]. This is due to_attr(which contains these tokens) being ignored:near-sdk-rs/near-sdk-macros/src/lib.rs
Lines 46 to 47 in 039cc11
There's a contract used in compilation test which has tokens after the attribute name:
#[near_bindgen(init => new)]. They are removed in this PR.Context
For
near-pluginswe're experimenting with passing extra tokens like#[near_bindgen(some_config(value_a, value_b))]. When adding logic to parse these tokens viadarlingthe compilation of the contract with#[near_bindgen(init => new)]fails.