rust: 1.77.0

[mina86]

Release notes: https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html

With split_last_chunk bunch of stdx code can now be deleted. \o/

As for other changes:

• Rust now doesn’t consider Clone and Debug derives as using fields of
  a type. This lead to a handful of dead_code warnings. I’ve fixed
  them by either removing offending type or adding allow(dead_code).

• Cargo package id format has been stabilised¹ and krates crate
  stopped working. Why do we care about that crate? It’s a dependency
  of cargo-deny. To have CI pass I’ve updated taiki-e/install-action
  so that it fetches the newest cargo-deny.

¹ rust-lang/cargo#12914

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.62%. Comparing base (69ba9f4) to head (8485598).

Files	Patch %	Lines
core/store/src/trie/mod.rs	0.00%	2 Missing ⚠️
chain/client/src/sync/external.rs	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10856      +/-   ##
==========================================
+ Coverage   71.39%   71.62%   +0.22%     
==========================================
  Files         764      758       -6     
  Lines      154001   151734    -2267     
  Branches   154001   151734    -2267     
==========================================
- Hits       109950   108672    -1278     
+ Misses      39046    38521     -525     
+ Partials     5005     4541     -464     

Flag	Coverage Δ
backward-compatibility	0.24% <0.00%> (+<0.01%)	⬆️
db-migration	0.24% <0.00%> (+<0.01%)	⬆️
genesis-check	1.42% <6.25%> (+<0.01%)	⬆️
integration-tests	37.38% <66.66%> (+0.52%)	⬆️
linux	70.24% <83.33%> (+0.22%)	⬆️
linux-nightly	71.12% <83.33%> (+0.22%)	⬆️
macos	54.68% <58.82%> (+0.07%)	⬆️
pytests	1.65% <6.25%> (+<0.01%)	⬆️
sanity-checks	1.44% <6.25%> (+<0.01%)	⬆️
unittests	67.26% <61.11%> (+0.15%)	⬆️
upgradability	0.29% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nagisa]

Was this complaining about the field within the struct here (and elsewhere?) Is there a more granular lint we can allow than dead_code? Cause this I believe will keep this struct (or enum) around even after it becomes truly unused.

[mina86]

Complain here I guess. ;)

But yeah, I’m not happy with this either. The best I can think of is to declare a dummy function with allow(dead_code) which accesses those fields.

[mina86]

Turns out types in chain/client/src/adapter.rs weren’t used and Clippy failed to detect that for some reason. Does derive marks type as used perhaps? In which case allow(dead_code) won’t prevent unused type detection.

[nagisa]

Turns out types in chain/client/src/adapter.rs weren’t used and Clippy failed to detect that for some reason. Does derive marks type as used perhaps?

Might very well be some of the derives creating a use that's not obvious. e.g. maybe they put the type id into some sort of type registry?

---

Complain rust-lang/rust#85200 I guess. ;)

Ah, I see. I actually agree with the reasoning in the PR and would remove the field here.

[nagisa]

Looks like the cargo-deny check is failing…

[mina86]

Yeah, that was next thing on my list. Had to update CI tools. Newer cargo-deny works fine.