-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update view-genesis command to view genesis in store #11809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in storage and config.
… into genesis-debug
… into genesis-debug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11809 +/- ##
==========================================
+ Coverage 71.72% 71.75% +0.03%
==========================================
Files 796 796
Lines 162984 163196 +212
Branches 162984 163196 +212
==========================================
+ Hits 116897 117100 +203
- Misses 41037 41043 +6
- Partials 5050 5053 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akhi3030
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously added the
neard view-state view-genesis
command to display the genesis block generated from code using the genesis json file. We used this command to debug the reason for the blockhash-mismatches between the genesis in the store/DB and the genesis computed from the config files using code.We extend the command to also display the genesis block stored in the DB.
Example usage to see the genesis in config and store and compare their hashes:
Also shorten the flag names to remove
view-
prefix since it is already as part of main command and sub command.