Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yield_resume): test MPC-style data id usage #11814

Merged
merged 4 commits into from
Jul 21, 2024

Conversation

saketh-are
Copy link
Collaborator

This PR improves coverage of yield execution in two ways:

  • The yield data id is written to storage when it's generated and subsequently retrieved from storage to make the resume call. This is similar to the approach being used in the MpcContract by the chain signatures use case.
  • The yield and resume calls are made in two separate transactions as close together as possible.

@saketh-are saketh-are marked this pull request as ready for review July 18, 2024 16:29
@saketh-are saketh-are requested a review from a team as a code owner July 18, 2024 16:29
@saketh-are saketh-are requested a review from akhi3030 July 18, 2024 16:29
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (db0644f) to head (7c2c1c3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11814      +/-   ##
==========================================
- Coverage   71.76%   71.75%   -0.01%     
==========================================
  Files         796      796              
  Lines      163183   163183              
  Branches   163183   163183              
==========================================
- Hits       117110   117099      -11     
- Misses      41025    41039      +14     
+ Partials     5048     5045       -3     
Flag Coverage Δ
backward-compatibility 0.23% <ø> (ø)
db-migration 0.23% <ø> (ø)
genesis-check 1.35% <ø> (ø)
integration-tests 37.81% <ø> (+<0.01%) ⬆️
linux 71.37% <ø> (-0.01%) ⬇️
linux-nightly 71.34% <ø> (-0.02%) ⬇️
macos 54.59% <ø> (-0.01%) ⬇️
pytests 1.62% <ø> (ø)
sanity-checks 1.42% <ø> (ø)
unittests 66.21% <ø> (-0.01%) ⬇️
upgradability 0.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saketh-are saketh-are added this pull request to the merge queue Jul 21, 2024
Merged via the queue into near:master with commit f8d9142 Jul 21, 2024
30 checks passed
@saketh-are saketh-are deleted the yield-resume-chain-sig-style-test branch July 21, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants