2.3.0 #12182
Merged
2.3.0 #12182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelo-gonzalez
requested review from
tayfunelmas,
saketh-are and
shreyan-gupta
saketh-are
approved these changes
Oct 1, 2024
| ### Protocol Changes | ||
| **No Changes** | ||
|
|
||
| ### Non-protocol Changes |
There was a problem hiding this comment.
Do we want to mention the state sync changes?
There was a problem hiding this comment.
Good point, somehow just forgot it. Added it now
CHANGELOG.md
Outdated
| ### Protocol Changes | ||
| * Sets `chunk_validator_only_kickout_threshold` to 70. Uses this kickout threshold as a cutoff threshold for contribution of endorsement ratio in rewards calculation: if endorsement ratio is above 70%, the contribution of endorsement ratio in average uptime calculation is 100%, otherwise it is 0%. Endorsements received are now included in `BlockHeader` to improve kickout and reward calculation for chunk validators. | ||
| * Changes the structure of ChunkEndorsements |
There was a problem hiding this comment.
I think this should come under non-protocol changes section. We are changing the network message tho, but that isn't a part of protocol I believe?
There was a problem hiding this comment.
yeah i just added it without looking too deeply because I saw it's included in the protocol features but you're right, def not strictly a protocol change. Actually let's just delete this part. I think it's prob not super relevant for most node operators.
It's not strictly a protocol change and most operators aren't going to find it relevant
marcelo-gonzalez
temporarily deployed
to
deploy
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps version strings and changelog messages for 2.3.0-rc.1