toolchain: update to Rust 1.68.0#8721
Merged
near-bulldozer[bot] merged 2 commits intonear:masterfrom Mar 14, 2023
Merged
Conversation
Routine update to the latest version of Rust. Release post: https://blog.rust-lang.org/2023/03/09/Rust-1.68.0.html I don't see anything exciting for nearcore in the release. Maybe `pin!` for custom futures could be useful. The commit also includes clippy renaming `derive_hash_xor_eq` to `derived_hash_with_manual_eq`. There is also a new [future incompatibility warning](rust-lang/rust#103418) which we hit in `fs_extra v1.2.0` and `wasmparser v0.78.2`. I don't think we can get rid of the second anytime soon, assuming we hang on to replayability.
nagisa
reviewed
Mar 14, 2023
core/crypto/src/signature.rs
Outdated
| // This `Hash` implementation is safe since it retains the property | ||
| // `k1 == k2 ⇒ hash(k1) == hash(k2)`. | ||
| #[allow(clippy::derive_hash_xor_eq)] | ||
| #[allow(clippy::derived_hash_with_manual_eq)] |
Contributor
There was a problem hiding this comment.
This, I believe, should no longer be necessary, as the rename is a part of the changes that now allow manual implementation of hash regardless of how the Eq implementation is produced.
Contributor
Author
There was a problem hiding this comment.
Ahh, yes makes sense. Removed them.
these are no longer needed
nikurt
approved these changes
Mar 14, 2023
nagisa
approved these changes
Mar 14, 2023
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine update to the latest version of Rust.
Release post: https://blog.rust-lang.org/2023/03/09/Rust-1.68.0.html
I don't see anything exciting for nearcore in the release.
Maybe
pin!for custom futures could be useful.The commit also includes clippy changes, they renamed
derive_hash_xor_eqtoderived_hash_with_manual_eqand changed the check. Now, we no longer need an
allow().There is also a new future incompatibility warning
which we hit in
fs_extra v1.2.0andwasmparser v0.78.2.I don't think we can get rid of the second anytime soon, assuming we
hang on to replayability.