(tx_indexer) Improvement to restore transactions in process from database to memcache #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayurii
force-pushed
the
tx_ind_without_db_cache
branch
3 times, most recently
from
5c9121b
to
e5fecf4
Compare
kobayurii
changed the title
khorolets
reviewed
Oct 26, 2023
kobayurii
force-pushed
the
tx_ind_without_db_cache
branch
from
483c080
to
467e098
Compare
kobayurii
force-pushed
the
tx_ind_without_db_cache
branch
from
cfac3c5
to
a8008fa
Compare
khorolets
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we improve restore transactions in process from database to memcache. The main idea is to restore not all transactions in the process but only transactions that the indexer could potentially collect. For this, we use the range of blocks from the beginning of the index to minus 1000 blocks. This range should include all transactions that the indexer can collect.
Another point, in this PR we solve the problem of missing receipts.
In 2021 on the nearcore side an unfortunate situation/bug occurred. For some transactions Receipts haven't been created and were considered as missing. It was fixed with the patch and the protocol upgrade. The protocol team decided to include those Receipts in the first block of the "next" epoch. However, the number of missing receipts was 383 and they didn't fit into a single block, so they were included in the two sequential blocks: 47317863 and 47317864 See the PR#4248