test: use separate database for testing #227
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| use std::env; | ||
| use tokio_postgres::NoTls; | ||
| use tracing::{error, info, warn}; | ||
|
|
||
| /// Get test database name from environment or default | ||
| pub fn get_test_db_name() -> String { | ||
| env::var("TEST_DATABASE_NAME").unwrap_or_else(|_| "platform_api_test".to_string()) | ||
| } | ||
|
|
||
| /// Get admin database name - try 'postgres' first, fallback to 'template1' if not available | ||
| async fn get_admin_db_name( | ||
| host: &str, | ||
| port: u16, | ||
| username: &str, | ||
| password: &str, | ||
| ) -> Result<String, String> { | ||
| // Try 'postgres' first (most common) | ||
| if can_connect_to_db(host, port, username, password, "postgres").await { | ||
| return Ok("postgres".to_string()); | ||
| } | ||
|
|
||
| // Fallback to 'template1' (always exists in PostgreSQL) | ||
| if can_connect_to_db(host, port, username, password, "template1").await { | ||
| warn!("'postgres' database not found, using 'template1' as admin database"); | ||
| return Ok("template1".to_string()); | ||
| } | ||
|
|
||
| Err("Neither 'postgres' nor 'template1' database found".to_string()) | ||
| } | ||
|
|
||
| async fn can_connect_to_db( | ||
| host: &str, | ||
| port: u16, | ||
| username: &str, | ||
| password: &str, | ||
| dbname: &str, | ||
| ) -> bool { | ||
| let conn_string = | ||
| format!("host={host} port={port} user={username} password={password} dbname={dbname}"); | ||
| tokio_postgres::connect(&conn_string, NoTls).await.is_ok() | ||
| } | ||
|
|
||
| pub async fn reset_test_database(config: &config::DatabaseConfig) -> Result<(), String> { | ||
| let test_db_name = get_test_db_name(); | ||
|
|
||
| // Safety check - only allow resetting test database | ||
| if !test_db_name.contains("test") { | ||
| panic!("Safety: Can only reset databases with 'test' in the name. Got: {test_db_name}"); | ||
| } | ||
|
|
||
| let host = config | ||
| .host | ||
| .clone() | ||
| .unwrap_or_else(|| "localhost".to_string()); | ||
| let port = config.port; | ||
| let username = config.username.clone(); | ||
| let password = config.password.clone(); | ||
|
|
||
| // Find available admin database | ||
| let admin_db = get_admin_db_name(&host, port, &username, &password).await?; | ||
|
|
||
| let conn_string = | ||
| format!("host={host} port={port} user={username} password={password} dbname={admin_db}"); | ||
|
|
||
| let (client, connection) = tokio_postgres::connect(&conn_string, NoTls) | ||
| .await | ||
| .map_err(|e| format!("Failed to connect to admin database: {e}"))?; | ||
|
|
||
| tokio::spawn(async move { | ||
| if let Err(e) = connection.await { | ||
| error!("Database connection error: {}", e); | ||
| } | ||
| }); | ||
|
|
||
| // Terminate existing connections to allow DROP | ||
| let _ = client | ||
| .execute( | ||
| &format!( | ||
| "SELECT pg_terminate_backend(pid) FROM pg_stat_activity | ||
| WHERE datname = '{test_db_name}' AND pid <> pg_backend_pid()" | ||
| ), | ||
| &[], | ||
| ) | ||
| .await; | ||
|
|
||
| // Drop database if exists | ||
| let drop_result = client | ||
| .execute(&format!("DROP DATABASE IF EXISTS {test_db_name}"), &[]) | ||
| .await; | ||
|
|
||
| if let Err(e) = drop_result { | ||
| warn!("Failed to drop test database (may not exist): {}", e); | ||
| } | ||
|
|
||
| // Create fresh database | ||
| client | ||
| .execute(&format!("CREATE DATABASE {test_db_name}"), &[]) | ||
| .await | ||
| .map_err(|e| format!("Failed to create test database: {e}"))?; | ||
|
Comment on lines
+76
to
+99
There was a problem hiding this comment. SQL injection vulnerability: The database name Use parameterized queries or properly quote/escape the database name. PostgreSQL identifiers should be wrapped in double quotes and escaped. Consider using the |
||
|
|
||
| info!("Test database '{}' reset successfully", test_db_name); | ||
| Ok(()) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: SQL injection vulnerability via unsanitized database name
The
test_db_namevalue from theDATABASE_TEST_NAMEenvironment variable is directly interpolated into SQL statements (DROP DATABASE IF EXISTS {test_db_name}andCREATE DATABASE {test_db_name}) without proper identifier quoting. The safety checktest_db_name.contains("test")can be bypassed by crafting a malicious value liketest"; DROP DATABASE production; --. Database identifiers in PostgreSQL need to be quoted with double quotes to prevent injection when used in DDL statements.Additional Locations (1)
crates/api/tests/common/db_setup.rs#L77-L81