-
Notifications
You must be signed in to change notification settings - Fork 0
fix: incorrect html labels #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an issue where HTML tags with attributes and special tags like <!DOCTYPE> were being incorrectly parsed by the reasoning tag processor. The fix ensures that only simple tag names (alphanumeric with _ or -) are checked against the reasoning tags list, while complex tags with attributes, special characters, or directives are preserved in their entirety.
Key Changes:
- Modified tag collection logic to capture full tag content including attributes and special characters
- Introduced
found_non_tag_charflag to distinguish simple tags from complex HTML/XML constructs - Added comprehensive tests for DOCTYPE and HTML tags with attributes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
@claude review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Some thoughts:
|
Fix #235
Note
Improve reasoning tag parsing to preserve HTML and handle self-closing/malformed cases, with extensive tests; ignore
.DS_Store.<!DOCTYPE>, tags with attributes).<br/>,<think/>) and avoids infinite loops on incomplete tags..gitignoreto ignore.DS_Store.Written by Cursor Bugbot for commit c0b6b34. This will update automatically on new commits. Configure here.