Skip to content

fix(test): add missing builder field in e2e telegram routing test#1398

Closed
reidliu41 wants to merge 1 commit intonearai:stagingfrom
reidliu41:fix/telegram-test-missing-builder
Closed

fix(test): add missing builder field in e2e telegram routing test#1398
reidliu41 wants to merge 1 commit intonearai:stagingfrom
reidliu41:fix/telegram-test-missing-builder

Conversation

@reidliu41
Copy link
Contributor

Summary

PR #712 added the builder field to AgentDeps but did not update the
test initializer in e2e_telegram_message_routing, causing compilation
failure under --features integration.

  • Add builder: None to the AgentDeps initializer to restore compilation

Change Type

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • CI/Infrastructure
  • Security
  • Dependencies

Linked Issue

Validation

  • cargo fmt
  • cargo clippy --all --benches --tests --examples --all-features
  • Relevant tests pass:
  • Manual testing:

Security Impact

Database Impact

Blast Radius

Rollback Plan


Review track:

  PR nearai#712 added the `builder` field to `AgentDeps` but did not update the
  test initializer in e2e_telegram_message_routing, causing compilation
  failure under `--features integration`.

  - Add `builder: None` to the AgentDeps initializer to restore compilation
@github-actions github-actions bot added the size: XS < 10 changed lines (excluding docs) label Mar 19, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compilation error within the end-to-end Telegram message routing test. It ensures that the test suite can successfully compile and run when the --features integration flag is enabled, by correctly initializing a dependency that was updated in a previous change.

Highlights

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Mar 19, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a compilation error in the e2e_telegram_message_routing test. The error was caused by a missing builder field in an AgentDeps struct initialization, which was introduced in a previous pull request. The change correctly adds builder: None to the initializer, resolving the compilation issue. The fix is straightforward and I have no further feedback.

@ilblackdragon
Copy link
Member

Thanks for contribution. This was already fixed in #1400.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules size: XS < 10 changed lines (excluding docs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants