fix(test): add missing builder field in e2e telegram routing test#1398
fix(test): add missing builder field in e2e telegram routing test#1398reidliu41 wants to merge 1 commit intonearai:stagingfrom
builder field in e2e telegram routing test#1398Conversation
PR nearai#712 added the `builder` field to `AgentDeps` but did not update the test initializer in e2e_telegram_message_routing, causing compilation failure under `--features integration`. - Add `builder: None` to the AgentDeps initializer to restore compilation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a compilation error within the end-to-end Telegram message routing test. It ensures that the test suite can successfully compile and run when the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes a compilation error in the e2e_telegram_message_routing test. The error was caused by a missing builder field in an AgentDeps struct initialization, which was introduced in a previous pull request. The change correctly adds builder: None to the initializer, resolving the compilation issue. The fix is straightforward and I have no further feedback.
|
Thanks for contribution. This was already fixed in #1400. |
Summary
PR #712 added the
builderfield toAgentDepsbut did not update thetest initializer in e2e_telegram_message_routing, causing compilation
failure under
--features integration.Add
builder: Noneto the AgentDeps initializer to restore compilationChange Type
Linked Issue
Validation
cargo fmtcargo clippy --all --benches --tests --examples --all-featuresSecurity Impact
Database Impact
Blast Radius
Rollback Plan
Review track: