Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tile display (buttons on hover, regular size) #22

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jun 24, 2024

Reference Issues or PRs

Fixes #17

Interaction on hover, and progress bar placement:

hover-and-download

Resizing behaviour:

resizing-behaviour

Test list:

  • Firefox
  • Chrome
  • Safari

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-gallery/improve-tile

only showing initial few lines of the description (more on hover)
showing progress bar above description on hover, ensuring tiles
are of consistent size and wrap nicely
@krassowski krassowski marked this pull request as ready for review June 26, 2024 19:17
@krassowski krassowski merged commit 05e4a87 into main Jun 28, 2024
6 checks passed
@krassowski krassowski deleted the improve-tile branch July 9, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the design of the gallery tiles
1 participant