Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass token authorization for SSE using MS implementation #44

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

krassowski
Copy link
Member

Reference Issues or PRs

Uses @microsoft/fetch-event-source implementation of event streams which allows to pass additional headers. It also uses page visibility API to close the connections when not needed, reducing the server load.

This allows to pass the token along which is required to authorize with JupyterHub when running on a different server than the main one.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@krassowski krassowski added the bug label Jul 27, 2024
Copy link

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-gallery/sse-with-headers

@krassowski krassowski marked this pull request as ready for review July 27, 2024 19:25
@krassowski krassowski merged commit ef56fc6 into main Jul 27, 2024
8 checks passed
@krassowski krassowski deleted the sse-with-headers branch July 28, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant