-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue12/git clone timeout #48
Open
andrewfulton9
wants to merge
13
commits into
nebari-dev:main
Choose a base branch
from
andrewfulton9:issue12/git_clone_timeout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue12/git clone timeout #48
andrewfulton9
wants to merge
13
commits into
nebari-dev:main
from
andrewfulton9:issue12/git_clone_timeout
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the status bar to go away on a timeout
3fd9d1f
to
7f898e8
Compare
The odd-cases ui-test appears to be flaky. Sometimes it passes, sometimes the Private Repository image fails to load so I get this: I imagine that the tests will often have to be updated to account for new stats for things like stars, contributers ect. of the example github repos in some of the gallery items. |
@krassowski, Could you give this a review when you get a chance? |
krassowski
reviewed
Jan 27, 2025
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Closes #12
Adds a configurable timeout for git clone
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Adds a test to ensure git clone timeout raises an error.
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?
I am not able to actually stop the thread running the git pull, so instead I just unblock the main thread on timeout. This means that the repo may still finish cloning even after the timeout. I tried to make it so that the status bar with the error message would go away if the repo is cloned despite the timeout, but it appears the
fileChanged
signal isn't triggered from the clone operation despite the the new folder being created. Is there another way to determine if the new folder is created? I think this may be related to #46. add the filesystem change isn't coming from within the filebrowser context