-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run integration tests against deployment #2962
base: main
Are you sure you want to change the base?
Run integration tests against deployment #2962
Conversation
f1e7883
to
f857acc
Compare
@marcelovilla yep, definitely can do. Just to clarify, you mean like update the ci workflows (eg. test_azure_integration.yaml) to use the change proposed by this PR? |
@soapy1 I was actually referring to the Regarding the use of the changes proposed in this PR for CI workflows in cloud integration tests, ideally, it would be great to have both local and cloud integration tests behave consistently, with the only difference being the deployment/destroy process. In other words, it would be beneficial if our tests could run against any Nebari cluster, regardless of how it was deployed. I’m not sure whether incorporating the changes from this PR into those CI workflows is the best approach or if we’d be better off having a separate workflow that allows running tests against any deployment. That is beyond the scope of this PR, but maybe it's worthwhile to keep it mind for the future. Let me know if this makes sense! |
1dc3f8b
to
1dfc35e
Compare
…inst an existing cloud
a3a0baf
to
f2e7ed0
Compare
@marcelovilla looks like tests are passing and this is setup correctly. This PR will make the |
Reference Issues or PRs
#2855, #2950
What does this implement/fix?
This PR updates the integration tests to support running against an existing cluster. You can do this by providing the
EXISTING_DEPLOYMENT_DIR
env var (opposed to the--cloud
flag) when running the integration tests.EXISTING_DEPLOYMENT_DIR
gets a path to an existing nebari config dir (must contain thenebari-config.yaml
and the output dir/stages
). For example seeHow to test this PR?
Also adds these tests to the Local Integration Tests GHA workflow.
Put a
x
in the boxes that applyTesting
How to test this PR?
Create a local deploy of nebari and then run the integration tests.