Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Container.Builder.singleton to Container.Builder.service #71

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Rename Container.Builder.singleton to Container.Builder.service #71

wants to merge 2 commits into from

Conversation

Sparky983
Copy link
Member

No description provided.

@Sparky983 Sparky983 added the proposal To propose changes that may not be implemented label Jul 30, 2023
@Sparky983 Sparky983 added this to the 0.3 milestone Jul 30, 2023
@Sparky983 Sparky983 marked this pull request as draft July 30, 2023 22:05
@codecov
Copy link

codecov bot commented Jul 30, 2023 •
edited
Loading

Codecov Report

Merging #71 (1b096d6) into main (e3072a3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #71   +/-   ##
=========================================
  Coverage     98.28%   98.28%           
  Complexity      148      148           
=========================================
  Files            26       26           
  Lines           467      467           
  Branches         46       46           
=========================================
  Hits            459      459           
  Misses            6        6           
  Partials          2        2
Files Changed Coverage Δ
...t/src/main/java/dev/nebulamc/inject/Container.java 100.00% <ø> (ø)
...a/dev/nebulamc/inject/test/ContainerExtension.java 100.00% <100.00%> (ø)
...va/dev/nebulamc/inject/internal/ContainerImpl.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
proposal To propose changes that may not be implemented
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
1 participant
@Sparky983