Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit error for invalid versions encountered during collect #101

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented Jul 17, 2023

Fixes #100

This changeset adds an explicit error message when scriv encounters an invalid version while running the collect command, including a hint to use scriv-end-here to mark the end of the part of a changelog that scriv should consider.

@nedbat nedbat force-pushed the bugfix/gh100-report-version-parse-failure branch from 9b89d7d to 60c2cf8 Compare July 18, 2023 19:25
@nedbat nedbat force-pushed the bugfix/gh100-report-version-parse-failure branch from bfbf812 to 4d762dc Compare July 18, 2023 20:43
@nedbat nedbat merged commit d959940 into nedbat:main Jul 18, 2023
22 checks passed
nedbat pushed a commit that referenced this pull request Jul 18, 2023
nedbat pushed a commit that referenced this pull request Jul 18, 2023
@nedbat
Copy link
Owner

nedbat commented Oct 12, 2023

This is now released as part of scriv 1.4.0.

@SnoopJ SnoopJ deleted the bugfix/gh100-report-version-parse-failure branch October 12, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scriv produces an obscure error when encountering an invalid Version during collection
2 participants