-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## [4.1.1] - 2023-09-05 ### Added - Added Quest 3 target device checkbox - Updated the `SystemHeadset` enum to include `Meta_Quest_3` and `Meta_Link_Quest_3` entries ### Changed - Added project validation rule and soft dependency to xr.core.utils package - Bumped up required XR Management version to 4.4.0 to fix issues with Android Manifest cleanup - Updated Oculus plugins to v56 - Updated documentation to inform users that Phase Sync is always active when using the Oculus OpenXR Runtime - Bumped minimum Unity version from 2022.2 to 2022.3 ### Fixed - Removed Android manifest cleanup that removed the manifest file, existing projects need to do a clean build to completely remove the issue - Fixed Android app issues that arise when setting the entry point to GameActivity ### Known Issues - `Unity.XR.Oculus.Stats.PerfMetrics` entries currently return `0` when using the OpenXR runtime - `Unity.XR.Oculus.Stats.AppMetrics` entries return `0` on all Oculus runtimes - For both of the above, the suggested replacement is to use the profiling tools available via the Oculus Developer Hub: https://developer.oculus.com/documentation/unity/ts-odh-logs-metrics/
- Loading branch information
Unity Technologies
committed
Sep 5, 2023
1 parent
7ce6390
commit 8fcd3b2
Showing
18 changed files
with
187 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| #if XR_CORE_UTILS && UNITY_EDITOR | ||
|
|
||
| using System.Linq; | ||
| using Unity.XR.CoreUtils.Editor; | ||
| using Unity.XR.Oculus; | ||
| using UnityEditor.XR.Management; | ||
| using UnityEngine.Rendering; | ||
|
|
||
| namespace UnityEditor.XR.Oculus | ||
| { | ||
| [InitializeOnLoad] | ||
| internal static class OculusProjectValidator | ||
| { | ||
| private const string ambientOcclusionScriptName = "ScreenSpaceAmbientOcclusion"; | ||
| private static readonly BuildTargetGroup[] buildTargetGroups = new BuildTargetGroup[] { BuildTargetGroup.Standalone, BuildTargetGroup.Android }; | ||
|
|
||
| static OculusProjectValidator() => AddValidationRules(); | ||
|
|
||
| private static void AddValidationRules() | ||
| { | ||
| foreach (var buildTargetGroup in buildTargetGroups) | ||
| { | ||
| var buildTargetRules = new BuildValidationRule[] | ||
| { | ||
| new BuildValidationRule() | ||
| { | ||
| Message = "Using the Screen Space Ambient Occlusion render feature results in significant performance overhead when the application is running natively on device. Disabling or removing that render feature is recommended.", | ||
| Category = "Oculus", | ||
| HelpText = "Only removing the Screen Space Ambient Occlusion render feature from all UniversalRenderer assets that may be used will make this warning go away, but just disabling the render feature will still prevent the performance overhead.", | ||
| FixItAutomatic = false, | ||
| IsRuleEnabled = () => | ||
| { | ||
| var settings = XRGeneralSettingsPerBuildTarget.XRGeneralSettingsForBuildTarget(buildTargetGroup); | ||
|
|
||
| if (settings) | ||
| return settings.Manager.activeLoaders.Any(typeof(OculusLoader).IsInstanceOfType); | ||
|
|
||
| return false; | ||
| }, | ||
| CheckPredicate = () => | ||
| { | ||
| // Checks the dependencies of all configured render pipeline assets. | ||
| foreach(var renderPipeline in GraphicsSettings.allConfiguredRenderPipelines) | ||
| { | ||
| var dependencies = AssetDatabase.GetDependencies(AssetDatabase.GetAssetPath(renderPipeline)); | ||
| foreach(var dependency in dependencies) | ||
| { | ||
| if (dependency.Contains(ambientOcclusionScriptName)) | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| BuildValidator.AddRules(buildTargetGroup, buildTargetRules); | ||
| } | ||
|
|
||
| } | ||
| } | ||
| } | ||
| #endif |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.