Skip to content

Commit

Permalink
Set legacy-peer-deps in .npmrc (#537)
Browse files Browse the repository at this point in the history
  • Loading branch information
dnaka91 authored Nov 5, 2022
1 parent a1df1cb commit 43bf925
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build_and_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
name: version_info
path: './src/version_info.json'

- run: npm install --legacy-peer-deps
- run: npm install
- run: npm run build:prepare
- run: npm run build:all

Expand Down Expand Up @@ -176,7 +176,7 @@ jobs:
with:
node-version: 16

- run: npm install --legacy-peer-deps
- run: npm install

- name: Download Angular Output from build
uses: actions/download-artifact@v2
Expand Down Expand Up @@ -226,7 +226,7 @@ jobs:
with:
node-version: 16

- run: npm install --legacy-peer-deps
- run: npm install

- name: Download Angular Output from build
uses: actions/download-artifact@v2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pullrequest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: 16
- run: npm install --legacy-peer-deps
- run: npm install
if: steps.cache-package.outputs.cache-hit != 'true'
- name: Run Affected Lint
shell: bash
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
with:
node-version: 16

- run: npm install --legacy-peer-deps
- run: npm install
if: steps.cache-package.outputs.cache-hit != 'true'
- run: npm run build:prepare
- run: npm run build:pkg -- -o release/out/memebox
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
legacy-peer-deps=true
save=true
save-exact=true
4 changes: 2 additions & 2 deletions BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ cd meme-box
If you want to build the _headless_ CLI variant use the following commands (for Windows in this example):

```sh
npm install --legacy-peer-deps
npm install
npm run build:prepare
npm run build:windows # or build:macos / build:linux
```
Expand All @@ -42,7 +42,7 @@ Afterwards, the standalone binary can be found in the `release/out/` folder.
If you want to build the complete Electron application, which includes the user interface bundled as a regular application, execute the following commands:

```sh
npm install --legacy-peer-deps
npm install
npm run electron:build
```

Expand Down

1 comment on commit 43bf925

@vercel
Copy link

@vercel vercel bot commented on 43bf925 Nov 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

meme-box – ./

meme-box.vercel.app
meme-box-git-develop-negu3.vercel.app
meme-box-negu3.vercel.app

Please sign in to comment.