Feature: add make:producer command #13
Conversation
This also introduces the idea of a non-explicit commit if autoCommit is true
For some reason these files were suddenly not found, but this works
| import { stubsRoot } from '../stubs/main.js' | ||
| import { CommandOptions } from '@adonisjs/core/types/ace' | ||
|
|
||
| export default class MakeProducer extends BaseCommand { |
There was a problem hiding this comment.
This file seems to not be emitted using the previous tsc / tsup configuration, hence needing to change.
| }, | ||
| ], | ||
| }) | ||
| } |
There was a problem hiding this comment.
This adds the export const DefaultProducer = await Kafka.createProducer('default') or if --producer webhooks then export const WebhookProducer = await Kafka.createProducer('webhooks') to #start/kafka.ts
It's a little cludgey but I think it's what we'd want.
| await codemods.makeUsingStub(stubsRoot, 'stubs/config/kafka.stub', {}) | ||
| await codemods.makeUsingStub(stubsRoot, 'stubs/start/kafka.stub', {}) | ||
| await codemods.makeUsingStub(stubsRoot, 'config/kafka.stub', {}) | ||
| await codemods.makeUsingStub(stubsRoot, 'start/kafka.stub', {}) |
There was a problem hiding this comment.
I have no idea why I needed to change these, but after adjusting tsc config, suddenly it didn't find the files correctly. Looking at other packages, and it seems I shouldn't have included the stubs/ originally.
There was a problem hiding this comment.
yeah, I had the reverse when I messed with this last, it wouldn’t work without stubs/ even though none of the examples I based this off had them and I tried this in an act of desperation. I’m glad this work correctly now.
| } | ||
| if (shouldInstallPackages) { | ||
| await codemods.installPackages([{ name: 'kafkajs', isDevDependency: false }]) | ||
| } |
There was a problem hiding this comment.
Even though kafka is a peerDep, this makes sure we install it. There isn't a way to specify a version here though. In theory the peerDep will have us covered, so maybe we don't need this (was inspired by lucid's configure.ts)
ThisIsMissEm
changed the title
ThisIsMissEm
force-pushed
the
feat/kafka-authentication
branch
from
9d5d98e to
f887cd0
Compare
This was really annoying to implement but gives us a
node ace make:producer <topic-name>which can optionally have a--producer <producerName>passed. The annoying part was mostly in that tsup / tsc wasn't emitting thebuild/commands/make_producer.jsfile, and no matter what I tried I couldn't get it to emit this file.This creates the
app/producers/<TopicName>.tsfile, and if necessary adds a producer to#start/kafka.ts:The
app/producers/<TopicName>.tsfile needs to be able to import the<ProducerName>Producerfrom#start/kafka.ts, hence doing a codemod and automatically adding it.E.g., in Webhooks, I would've run:
Which would have given me the files that I have in that branch.
If you omit
--producer <produceName>then it creates a default producer for you calledDefaultProducerand automatically inserts that to#start/kafka.tsif necessary.