Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
news
entryUnify usage of ruamel and yaml
This PR refactors the codebase to use ruamel instead of yaml.
There is one file left, where a refactor does not make sense in my opinion:
conda-smithy/variant_algebra.py
The first problem is, that ruamel returns
None
for empty values, so we had to override thevariants.trim_empty_keys(content)
to make it work.Secondly, yaml returns numbers as string and ruamel does not. Parsing the version numbers to float causes several issues because the trailing zeros are not correct.
This is a rabbit hole 🐇 and we decided to keep it as it is, finally.