Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/yaml ruamel #7

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Refactor/yaml ruamel #7

wants to merge 8 commits into from

Conversation

hulkoba
Copy link

@hulkoba hulkoba commented Jun 4, 2024

Checklist

  • Added a news entry

Unify usage of ruamel and yaml

This PR refactors the codebase to use ruamel instead of yaml.

There is one file left, where a refactor does not make sense in my opinion: conda-smithy/variant_algebra.py

The first problem is, that ruamel returns None for empty values, so we had to override the variants.trim_empty_keys(content) to make it work.
Secondly, yaml returns numbers as string and ruamel does not. Parsing the version numbers to float causes several issues because the trailing zeros are not correct.
This is a rabbit hole 🐇 and we decided to keep it as it is, finally.

@coveralls
Copy link

coveralls commented Jun 4, 2024

Pull Request Test Coverage Report for Build 9613167164

Details

  • 22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 67.914%

Totals Coverage Status
Change from base Build 9612517554: 0.04%
Covered Lines: 2799
Relevant Lines: 4042

💛 - Coveralls

@hulkoba hulkoba force-pushed the refactor/yaml_ruamel branch 3 times, most recently from 77bc2ec to 9d09085 Compare June 5, 2024 07:48
@hulkoba hulkoba force-pushed the refactor/yaml_ruamel branch 4 times, most recently from ea29add to 0d47858 Compare June 21, 2024 08:18
@AlbaHerrerias AlbaHerrerias force-pushed the refactor/yaml_ruamel branch from 0d47858 to f5b3983 Compare June 21, 2024 11:43
@AlbaHerrerias AlbaHerrerias force-pushed the refactor/yaml_ruamel branch from f5b3983 to 370b788 Compare June 21, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants