forked from apache/logging-log4j2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor log4j core test #8
Draft
ninetteadhikari
wants to merge
79
commits into
2.x
Choose a base branch
from
refactor-log4j-core-test
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninetteadhikari
force-pushed
the
refactor-log4j-core-test
branch
3 times, most recently
from
October 29, 2024 10:48
8708aed
to
63668a3
Compare
hulkoba
force-pushed
the
refactor-log4j-core-test
branch
4 times, most recently
from
November 7, 2024 13:38
7609f81
to
39a1494
Compare
ninetteadhikari
force-pushed
the
refactor-log4j-core-test
branch
2 times, most recently
from
November 8, 2024 16:28
d56c0fd
to
9e383df
Compare
hulkoba
force-pushed
the
refactor-log4j-core-test
branch
8 times, most recently
from
November 15, 2024 11:35
d02b57e
to
5397e79
Compare
ninetteadhikari
force-pushed
the
refactor-log4j-core-test
branch
from
November 15, 2024 13:02
c009122
to
8da0671
Compare
hulkoba
force-pushed
the
refactor-log4j-core-test
branch
from
November 18, 2024 09:57
a4803c2
to
a0251e7
Compare
ninetteadhikari
force-pushed
the
refactor-log4j-core-test
branch
4 times, most recently
from
November 25, 2024 09:33
7dc33e7
to
28d5094
Compare
ninetteadhikari
force-pushed
the
refactor-log4j-core-test
branch
from
November 27, 2024 08:58
28d5094
to
898d2d3
Compare
jcoglan
force-pushed
the
refactor-log4j-core-test
branch
from
December 4, 2024 09:17
9563a0f
to
39eba43
Compare
This reverts commit f36fa0e.
This branch and
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed
Milestone 1. Upgrade from JUnit 4 to JUnit 5
. This PR migrates the tests located inx
to JUnit5.cPlease note the
log4j-core-test
module contains over 150 files and this PR updates the tests for 40 of them. Further PRs will be made to update the rest of the tests.Checklist
2.x
branch if you are targeting Log4j 2; usemain
otherwise./mvnw verify
succeeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:apply
and retry)src/changelog/.2.x.x
directory