Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor log4j core test #8

Draft
wants to merge 79 commits into
base: 2.x
Choose a base branch
from
Draft

Conversation

ninetteadhikari
Copy link
Member

@ninetteadhikari ninetteadhikari commented Oct 21, 2024

Introduction

We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5. This PR migrates the tests located in x to JUnit5.c

Please note the log4j-core-test module contains over 150 files and this PR updates the tests for 40 of them. Further PRs will be made to update the rest of the tests.

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

Copy link

github-actions bot commented Oct 21, 2024

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan NOT_PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan NOT_PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan NOT_PUBLISHED
Generated by gradle/develocity-actions

@ninetteadhikari ninetteadhikari force-pushed the refactor-log4j-core-test branch 3 times, most recently from 8708aed to 63668a3 Compare October 29, 2024 10:48
@hulkoba hulkoba force-pushed the refactor-log4j-core-test branch 4 times, most recently from 7609f81 to 39a1494 Compare November 7, 2024 13:38
@ninetteadhikari ninetteadhikari force-pushed the refactor-log4j-core-test branch 2 times, most recently from d56c0fd to 9e383df Compare November 8, 2024 16:28
@hulkoba hulkoba force-pushed the refactor-log4j-core-test branch 8 times, most recently from d02b57e to 5397e79 Compare November 15, 2024 11:35
@ninetteadhikari ninetteadhikari force-pushed the refactor-log4j-core-test branch from c009122 to 8da0671 Compare November 15, 2024 13:02
@hulkoba hulkoba force-pushed the refactor-log4j-core-test branch from a4803c2 to a0251e7 Compare November 18, 2024 09:57
@ninetteadhikari ninetteadhikari force-pushed the refactor-log4j-core-test branch 4 times, most recently from 7dc33e7 to 28d5094 Compare November 25, 2024 09:33
@ninetteadhikari ninetteadhikari force-pushed the refactor-log4j-core-test branch from 28d5094 to 898d2d3 Compare November 27, 2024 08:58
@jcoglan jcoglan force-pushed the refactor-log4j-core-test branch from 9563a0f to 39eba43 Compare December 4, 2024 09:17
Realtin and others added 29 commits December 6, 2024 10:56
@AlbaHerrerias
Copy link

This branch and refactor-log4j-core-test1 (mind the 1) differ in the following files, which I deleted in refactor-log4j-core-test1. I deleted them because they add no value. The changes these files have were introduced before the big JUnit5 automatic refactor not made by us, but after the conflict resolution they ended up looking like this.

log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/OutputStreamAppenderTest.java
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderOnStartup2Test.java
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderOnStartupDirectTest.java
log4j-core-test/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerClassLoadDeadlockTest.java
log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/NestedLoggerConfigTest.java
log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/plugins/convert/DateTypeConverterTest.java
log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/plugins/convert/TypeConverterRegistryTest.java
log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/plugins/convert/TypeConvertersTest.java
log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/plugins/util/ResolverUtilCustomProtocolTest.java
log4j-core-test/src/test/java/org/apache/logging/log4j/core/layout/JsonLayoutTest.java
log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/NameAbbreviatorTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants