fix PHP Deprecated #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix PHP Deprecated: Implicit conversion from float to int loses precision adding floor() on lines 201, 210, 219, 224, 232 for compat PHP 8.1
|
If this project isn't dead, it'd be easier for someone to approve/merge this PR if the diff only contained the actual fixes mentioned ... (and not e.g reindentation, as welcome as it may be!). |
|
@neitanod is there any hope about merging some fixes? Would add maintainers be an options to let the project die? Thanks in advance |
spekulatius
approved these changes
Dec 8, 2022
|
@neitanod if it was possible could you update the library with fixes for PHP 8.1 ? |
|
@andreamk I'd suggest moving to https://packagist.org/packages/fylax/forceutf8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix PHP Deprecated: Implicit conversion from float to int loses precision
adding floor() on lines 201, 210, 219, 224, 232
for compat PHP 8.1