Resolving Content Alignment Issue with "Jump to Previous" and "Jump to Next" Buttons #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cplee
approved these changes
Feb 23, 2024
|
Hey @cplee one more review is required? |
|
I can do the second review this afternoon... It would help me if we could somehow get a live preview per PR on GitHub Pages, but that's only my own small issue with reviews of style changes. |
ChristopherHX
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
What is better
- All width doesn't overlap prev/next buttons with content
- 1920px and 800px with not affected by the problem
What is suboptimal now
- 1920px width is no longer filled with content
=> My Conclusion better not altering predefined styles to avoid UI glitches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #15, where the content alignment within the body of the page was not properly configured. Specifically, the "Jump to Previous" and "Jump to Next" buttons were colliding with the main text of the body, resulting in inconsistencies in the display and functionality of the page.
To fix this issue, I have adjusted the CSS to remove the fixed length assigned to the root element, allowing for proper alignment and spacing throughout the page.
This resolves the alignment inconsistencies and restores the intended functionality of the page. Please review and merge accordingly.
Thank you.
Installation.-.act.-.User.Guide.-.Google.Chrome.2024-02-13.12-49-33.mp4