Skip to content

Conversation

@eakoli
Copy link

@eakoli eakoli commented Sep 11, 2025

Ensure that the job context properly exposes the container network

https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#job-context

@mergify mergify bot added the needs-work Extra attention is needed label Sep 13, 2025
@codecov
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.88%. Comparing base (bd4bc99) to head (15f3c97).
⚠️ Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
pkg/runner/run_context.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5927      +/-   ##
==========================================
+ Coverage   74.65%   74.88%   +0.22%     
==========================================
  Files          73       73              
  Lines       11139    11207      +68     
==========================================
+ Hits         8316     8392      +76     
+ Misses       2186     2180       -6     
+ Partials      637      635       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@fvalverd fvalverd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eakoli these two suggestions will fix the linter

@eakoli eakoli force-pushed the feat-container-network branch from 526a9d1 to dc8ecfd Compare October 21, 2025 19:11
@fvalverd
Copy link

Hi @panekj @cplee, I hope everything is going well. I'm tagging you in here because I saw you from other merged PRs. I would like to ask you if you can take a look at this PR, I didn't write it, and also I don't know go enough to add value in this PR, but I'm very much interested in having the container network information available from act in order to debug better my CI locally, any sort of feedback helps 🙏

@panekj
Copy link
Contributor

panekj commented Oct 23, 2025

I can't merge anything, the process is broken and it can be fixed only by #5944

@panekj
Copy link
Contributor

panekj commented Oct 23, 2025

I recommend using https://github.com/actions-oss/act-cli as it's better maintained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-work Extra attention is needed size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants