feat: wait load js for lms#5
Merged
andrey-canon merged 2 commits intoopen-release/teak.nelpfrom Dec 1, 2025
Merged
Conversation
* chore: append script to the element * refactor: move async behaviour for main function With pr suggestion the async behaviour is only used to load the promises of loading scripts. Then xblock is called if all js files load as expected. Also StaffGradedAssignmentXBlock is preserved not async, so now we wait for loadJs promises.
andrey-canon
changed the base branch from
teak-mig/FUTUREX-1219
to
open-release/teak.nelp
andrey-canon
temporarily deployed
to
open-release/teak.nelp
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix cloudfront compatibility with missing js files loads.
This ensure to load the extra js files before xblock is called.
Migration pr of #1
Issue # 1240