Skip to content

fix: this checks that the course has an end date before rendering cer…#65

Merged
andrey-canon merged 1 commit intoopen-release/teak.nelpfrom
teak-mig/FUTUREX-1281
Oct 21, 2025
Merged

fix: this checks that the course has an end date before rendering cer…#65
andrey-canon merged 1 commit intoopen-release/teak.nelpfrom
teak-mig/FUTUREX-1281

Conversation

@andrey-canon
Copy link
Collaborator

Description

This adds a new condition that limits the certificate status message based on the end date. This is a migration pr of #39
Issue # 1281

Before

image

After

image

How to test

To replicate this issue, the response from {lms_host}/api/course_home/progress/{course_id} must contain "certificate_data": null. If your course is new, you only need to set a valid user mode, and that’s enough.

  1. Ensure that your user has a valid certificate mode (e.g., honor). You can change this in the admin panel.
  2. Go to your test course and then open the Progress tab.
  3. Check out this branch.
  4. Verify that the message has disappeared.

Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is small. Anyway, I tried to replicate the error msg and I could do it, @andrey-canon could you tell me what else is missing in my configurations

Screencast.from.02-10-25.09.11.45.webm

@andrey-canon andrey-canon force-pushed the teak-mig/FUTUREX-1281 branch from 1f0c8dc to 2dc5280 Compare October 7, 2025 17:00
@andrey-canon andrey-canon changed the base branch from teak-mig/FUTUREX-1285 to open-release/teak.nelp October 7, 2025 17:02
@johanseto johanseto self-requested a review October 20, 2025 21:06
Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Working with a new course, and only adding a user with course enrollment honor.
image

2025-10-20_16-05
Screencast.from.20-10-25.16.05.51.webm

@andrey-canon andrey-canon force-pushed the teak-mig/FUTUREX-1281 branch from 2dc5280 to 0886b3a Compare October 21, 2025 16:56
@andrey-canon andrey-canon merged commit 23b3bca into open-release/teak.nelp Oct 21, 2025
3 checks passed
@andrey-canon andrey-canon temporarily deployed to open-release/teak.nelp October 21, 2025 16:56 — with GitHub Actions Inactive
@andrey-canon andrey-canon temporarily deployed to open-release/teak.nelp October 21, 2025 16:56 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants