Add composable contract templates #1416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
shargon
reviewed
Oct 30, 2025
Comment on lines
+17
to
+24
| contract_name="$1" | ||
| shift | ||
|
|
||
| template="Basic" | ||
| features=() | ||
|
|
||
| if [[ $# -gt 0 ]]; then | ||
| template="$1" |
There was a problem hiding this comment.
The arguments should be sanitized because it goes to the command line
# Sanitize: allow only alphanumeric, underscore, and dash
if [[ ! "$contract_name" =~ ^[a-zA-Z0-9_-]+$ ]]; then
echo "Error: Invalid contract name. Only letters, numbers, '_' and '-' are allowed."
exit 1
fi
shargon
reviewed
Oct 30, 2025
| UInt160 previous = GetOwner(); | ||
| Storage.Put(new[] { Prefix_Owner }, newOwner); | ||
| Storage.Put(Storage.CurrentContext, OwnerKey, newOwner); |
There was a problem hiding this comment.
We can use Local, it's cheaper (no context required), safer and easier
tests/Neo.Compiler.CSharp.UnitTests/UnitTest_TemplateManager.cs
Outdated
Show resolved
Hide resolved
| public void TestGenerateFeaturesNep11Ownable() | ||
| { | ||
| string projectName = "FeatureNep11Ownable"; | ||
| _templateManager.GenerateContractFromFeatures(new[] { "NEP11", "Ownable" }, projectName, _testOutputPath); |
There was a problem hiding this comment.
Should be good if we compile the template results, otherwise it will be hard to detect if we make something wrong, only users who use it will know it
|
Can this be like 'dotnet new console', even without extra scripts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary