Skip to content

Correctly implementing the Dispose Pattern #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikzhang merged 2 commits into from
Dec 12, 2025
Merged

Correctly implementing the Dispose Pattern #541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27ff638
Correctly implementing the Dispose Pattern
erikzhang Dec 11, 2025
41eba80
Merge branch 'master' into dispose
shargon Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Neo.VM/ExecutionEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,20 @@ protected ExecutionEngine(JumpTable? jumpTable, IReferenceCounter referenceCount
ResultStack = new(referenceCounter);
}

public virtual void Dispose()
public void Dispose()
{
InvocationStack.Clear();
Dispose(true);
GC.SuppressFinalize(this);
}

protected virtual void Dispose(bool disposing)
{
if (disposing)
{
InvocationStack.Clear();
}
}

/// <summary>
/// Start execution of the VM.
/// </summary>
Expand Down