Implement BIP-0032 #4414
Merged
Implement BIP-0032 #4414
+305
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Jan 5, 2026
shargon
approved these changes
Jan 5, 2026
Wi1l-B0t
reviewed
Jan 5, 2026
| for (int i = 0; i < count; i++) | ||
| { | ||
| indices[i] = uint.Parse(match.Groups["index"].Captures[i].Value); | ||
| if (indices[i] >= 0x80000000) throw new FormatException(); |
Contributor
There was a problem hiding this comment.
Define 0x80000000 as a constant?
Member
Author
There was a problem hiding this comment.
Here, 0x80000000 is a common method for determining whether the highest bit is 1, and it is not a special constant.
Wi1l-B0t
reviewed
Jan 5, 2026
| public static KeyPath Parse(string path) | ||
| { | ||
| Match match = KeyPathRegex().Match(path); | ||
| if (!match.Success) throw new FormatException(); |
Contributor
There was a problem hiding this comment.
Add message to throw exception ?
Member
Author
There was a problem hiding this comment.
The default message is enough.
Jim8y
approved these changes
Jan 5, 2026
Merged
ajara87
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.