Skip to content

Conversation

@erikzhang
Copy link
Member

Preparing to add DHT functionality to the P2P protocol.

@github-actions github-actions bot added the N4 label Jan 8, 2026
}

private void Serialize(BinaryWriter writer, bool withSignature)
void Serialize(BinaryWriter writer, bool withSignature)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove private keyword? It needs to be clear Identification of access modifier for the method visibility. Whether it be public, private, internal, and protected.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private is the default one.

Copy link
Member

@cschuchardt88 cschuchardt88 Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on the compilers and/or IDE environment and default configurations for them. Well I just going to saying it. I fought ever since I started working with neo to get to some kind of standard for our code. So it eliminates down time for developers, whether they be new or existing for this open source project. So everything is clean, neat, all the same and simple to understand/debug/test and add new features. So, I created an .editorconfig file with restrictions for safe pointing and stopping messy and error proven code or lazy coding from sneaking in the repo. But its seems everything that was configured and setup is all now removed. I don't think its smart to have half the code look like spaghetti or using different coding styles.

I came up with these coding rules for developers. So anyone can easy jump in and understand what is going in the code. Which we all agreed upon.
https://github.com/neo-project/.github/blob/d83897afb4fd5bd3c107a8dfd845e6dcf1e8d713/docs/neo-coding-rules.md

Copy link
Member Author

@erikzhang erikzhang Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/access-modifiers#class-and-struct-accessibility

According to Microsoft's official documentation, by default, class and struct members, including nested classes and structs, have private access. So it doesn't depend on the compilers and/or IDE environment.

But if you strongly insist, we can add private later. It's not a big problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior is consistent across all compilers and .NET versions because it is part of the C# Language Specification enforced by the Roslyn compiler.

Copy link
Member

@ajara87 ajara87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikzhang erikzhang merged commit ccfc1aa into neo-project:master Jan 9, 2026
7 checks passed
@erikzhang erikzhang deleted the nodeid branch January 9, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants