Skip to content

Conversation

@shargon
Copy link
Member

@shargon shargon commented Jun 8, 2022

@shargon shargon requested a review from erikzhang June 8, 2022 14:40
@roman-khimov
Copy link
Contributor

Yep, #126 (comment)

@shargon
Copy link
Member Author

shargon commented Jun 8, 2022

Yep, #126 (comment)

Maybe we can add just a note, this syscall will compare against the callingScriptHash first..?

@erikzhang
Copy link
Member

We need to explain what the contract is supposed to do and give the best practices for doing it in one step using CheckWitness.

@shargon
Copy link
Member Author

shargon commented Jun 10, 2022

We need to explain what the contract is supposed to do and give the best practices for doing it in one step using CheckWitness.

We can add a note like this Take into account that <code>Neo.Runtime.CheckWitness</code> already will check whether the <code>from</code> address equals the caller contract hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants