Improve Feature-Attribute handling #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Andy2003
force-pushed
the
feature/refactor-feture-attribute-handling
branch
from
13e0e2b to
3eeee71
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors extra‐property handling by replacing array‐based APIs with map/set‐based ones, adds dynamic attribute discovery/storage, and updates tests, encoders, and procedures to use the new API.
- Migrated all
getExtraPropertyNamesusages togetExtraPropertiesreturningMap<String,Class<?>>, andString[]→Set<String>in pipes. - Added dynamic metadata capture in
EditableLayerImpl(viamemorizeNodeMeta/saveAttributeMeta) and deprecated manual setters. - Updated all geometry encoders and feature builders to expose
getEncoderProperties.
Reviewed Changes
Copilot reviewed 34 out of 39 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| EditableLayerImpl.java | Implements dynamic property discovery and metadata storage |
| EditableLayerImpl.java | Deprecates manual setters; adds mergeExtraPropertyNames |
| AbstractGeometryEncoder.java | Adds getEncoderProperties |
| *Encoder.java (all encoders) | Expose getEncoderProperties; replace literals with constants |
| SpatialProcedures.java | Renames StringResult → FeatureAttributeResult |
| GeoPipeline.java / CopyDatabaseRecordProperties.java / GeoPipeFlow.java | Switch from arrays to Set<String> for extra property keys |
| Neo4jFeatureBuilder.java / Neo4jSpatialFeatureSource.java / etc. | Update feature builders/sources to consume Map<String,Class<?>> |
All tests (*Tests.java) |
Updated imports and invocations to use new map/set API |
| Constants.java | Adds PROP_PREFIX_EXTRA_PROP_V2 |
server-plugin/src/main/java/org/neo4j/gis/spatial/AbstractGeometryEncoder.java
Show resolved
Hide resolved
server-plugin/src/main/java/org/neo4j/gis/spatial/encoders/NativePointsEncoder.java
Show resolved
Hide resolved
server-plugin/src/main/java/org/neo4j/gis/spatial/rtree/RTreeImageExporter.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors feature-attribute handling across the plugin by replacing
String[]-based APIs withMap<String,Class<?>>andSet<String>for extra properties, adding dynamic attribute discovery/storage in layers, and updating tests and encoders to use the new API.getExtraPropertyNamesand related APIs togetExtraPropertiesreturning aMap<String,Class<?>>.CopyDatabaseRecordProperties,GeoPipeline,GeoPipeFlow, and other classes to useSet<String>instead ofString[].EditableLayerImpland deprecate manualsetFeatureAttributes.