Skip to content

close review gaps, fix schema-DDL splitter, improve test coverage - #61

Merged
johnymontana merged 6 commits into
mainfrom
update-ci-runs
Sep 4, 2026
Merged

close review gaps, fix schema-DDL splitter, improve test coverage#61
johnymontana merged 6 commits into
mainfrom
update-ci-runs

Conversation

@johnymontana

Copy link
Copy Markdown
Collaborator

Summary

Reviews the five community PRs merged since v0.13.1, fixes the gaps found reviewing them, adds test
coverage at every level of the CI pipeline, and preps the v0.14.0 release (changelog, docs, version bump).

Gaps closed in the merged PRs

Pre-existing bug exposed by the new integration coverage

Every schema-DDL consumer split on ; and skipped fragments starting with // — silently dropping
the five indexes/constraints behind comment headers (person_name, document_title,
document_domain, document_name_unique, local_file_fulltext were never created by
make seed/ingest) and executing a comment tail as garbage Cypher (CypherSyntaxError on every
schema apply). New shared split_cypher_statements() fixes ingest.py, the generated
generate_data.py, and test_integration.py.

Test coverage added (all in existing CI jobs)

  • Unit: new tests/test_generated_client_runtime.py (26 tests) executes the rendered
    context_graph_client.py + memory.py against doubles — NAMS dispatch/coercion/tool events,
    bolt database= threading, store_message error recording, /health error classifier. Plus +12 CLI,
    +5 wizard, +17 template-pin, +9 ontology, +3 custom-domain tests.
  • App-level: +6 in test_routes_integration.py/cypher on NAMS, 503 guards, live store
    failure flipping /health to degraded and recovering.
  • Integration (--integration): explicit-database ingest, validate_connection accept/reject,
    schema DDL asserted to create the previously-dropped indexes.
  • E2E: generated test_routes.py gains two backend-specific /health tests (slow runner now also
    scaffolds a bolt project and asserts they ran); e2e_smoke_test.py asserts the /health contract
    shape per backend.

Release prep

CHANGELOG.md v0.14.0 section (features credited per PR author), version 0.13.1 → 0.14.0
(pyproject.toml, __init__.py, uv.lock), docs updated (cli-options.md, Aura guide,
custom-domain guide, generated-project-structure, whats-new.md, generated README), CLAUDE.md
status + counts refreshed. No CI workflow changes needed.

Test plan

  • Fast suite: 1,429 passed, 262 skipped (was 1,349)
  • Full --slow --functional suite (CI matrix job): 1,677 passed
  • pytest tests/test_integration.py --integration vs throwaway Neo4j 5: 10/10 (2 pre-existing failures fixed)
  • Generated test suites executed in real venvs for NAMS and bolt scaffolds
  • ruff check src/ tests/ scripts/ clean

Comment thread tests/test_ingest_nams.py Fixed
@johnymontana
johnymontana merged commit eb7fa1a into main Sep 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants