-
Notifications
You must be signed in to change notification settings - Fork 22
Editorial review #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Editorial review #661
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
17ab0bf
editorial review part 1
rsill-neo4j cd817be
Merge branch 'main' into editorial-review
rsill-neo4j 34906f9
Merge branch 'main' into editorial-review
rsill-neo4j e0fc095
Merge branch 'main' into editorial-review
rsill-neo4j 83eaa71
create clause
rsill-neo4j 0dc042d
clauses
rsill-neo4j 6f021ae
Merge branch 'main' into editorial-review
rsill-neo4j 8f1d322
Apply suggestions from code review
rsill-neo4j 922d188
addressing review comments
rsill-neo4j File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,8 +4,7 @@ | |
|
|
||
| This page describes how to add a link:https://neo4j.com/docs/cypher-manual/current/clauses/create/[`CREATE`] clause with the `Cypher.Create` class. | ||
|
|
||
| To make a `CREATE` clause, first create a valid pattern using the xref:/patterns.adoc[Pattern] class: | ||
|
|
||
| To add the clause, first create a valid pattern using the xref:/patterns.adoc[Pattern] class: | ||
|
|
||
| [source, javascript] | ||
| ---- | ||
|
|
@@ -39,8 +38,8 @@ This generates the following `CREATE` clause: | |
| CREATE (this:Movie {title: "The Matrix"}) | ||
| ---- | ||
|
|
||
| == Relationships | ||
|
|
||
| == Relationships | ||
|
|
||
| Relationships can be used in a match clause by creating the relevant xref:/patterns.adoc[Pattern]: | ||
|
|
||
|
|
@@ -62,9 +61,9 @@ CREATE (this1:`Person`)-[this0:ACTED_IN]->(this2:`Movie`) | |
|
|
||
| == Update properties | ||
|
|
||
| The clauses `SET` and `REMOVE` can be added with the methods `.set` and `.remove` respectively. | ||
| Add the `SET` and `REMOVE` clauses with the methods `.set` and `.remove` respectively. | ||
|
|
||
| `.set` take tuples of 2 elements, the first being the property to update and the second the value: | ||
| `.set` takes a tuple of two elements - a property to update and a new value: | ||
|
||
|
|
||
| [source, javascript] | ||
| ---- | ||
|
|
@@ -82,7 +81,6 @@ SET this0.title = $param0 | |
|
|
||
| Multiple properties can be updated by passing multiple tuples. | ||
|
|
||
|
|
||
| `.remove` takes the properties to remove: | ||
rsill-neo4j marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| [source, javascript] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page relates to
CREATEclause, but I feel it may still be confusing to just refer to it as "the clause". In many places we need to either use multiple clauses or we may reference other clauses, so even at the risk of it being a bit verbose, I'd prefer for the create to be explicitly referenced