Add more style fixes #464
Add more style fixes #464
Conversation
|
@nvitucci hey, is there any thing else we need to do here? |
No, you can go on and accept the changes if that's fine with you. |
|
OK, I just think there are 2 you could take a look at where it's added |
| @@ -47,7 +47,7 @@ To clone an instance protected by a Customer Managed Key, the key must be valid | |||
| The cloned instance, by default, uses the available Customer Managed Key for that region and product. | |||
|
|
|||
| It is best practice to use the same CMK key as the instance it’s being cloned from. | |||
| You can override this to use another CMK key - but you can not use the Neo4j Managed Key. | |||
| You can override this to use another CMK key--but you can not use the Neo4j Managed Key. | |||
There was a problem hiding this comment.
It added an addition dash - on line 50
There was a problem hiding this comment.
Yes, this would be the correct way to insert an emdash in Asciidoc.
| @@ -107,7 +107,7 @@ Move through the tabs to enable to following: | |||
| .. Inside the key vault, go to *Access Control (IAM)* and *add role assignment*. | |||
| .. In the *Role* tab, select *Key Vault Administrator*. | |||
| .. In the *Member* tab, select *User, group, or service principal*. | |||
| .. *Select members* and select yourself or the relevant person, then *Review + Assign*. | |||
| .. Select *Select members* and select yourself or the relevant person, then *Review + Assign*. | |||
There was a problem hiding this comment.
too many uses of the word "select" on this line
There was a problem hiding this comment.
True, but there is "Select" (the action) and the "Select members" (the text for the button). I think this is consistent for example with the suggestion in the Google style guide.
Maybe there is a better way to rephrase?
Co-authored-by: Jessica Wright <[email protected]>
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
No description provided.