-
Notifications
You must be signed in to change notification settings - Fork 64
Graph types #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Graph types #1391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have to actually review the graph type pages 🙈 but these are my comments so far XD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of the syntax page (found errors in my syntax I had given you, sorry about that) and the updates after last review.
Still have the graph type chapter/pages left to look at, but that'll have to be tomorrow instead I think.
Status: 1 side note comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of updates, no progress on the parts I haven't looked at yet
modules/ROOT/pages/schema/graph-types/drop-graph-type-elements.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got through the last files as well 🎉
modules/ROOT/pages/schema/graph-types/drop-graph-type-elements.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/schema/graph-types/drop-graph-type-elements.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next round of comments
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc
Outdated
Show resolved
Hide resolved
SHOW CURRENT GRAPH TYPE | ||
---- | ||
|
||
.Result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(also applies to the next result)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new comments, fancy that 🎉 (though you do have test failures)
Co-authored-by: Therese Magnusson <[email protected]>
This PR includes documentation updates New pages:
Updated pages: |
ToDo:
Clarify graph types wrt GQL appendix
Replace 2025.xx with actual month of release (currently not confirmed)
When VECTOR property type constraints #1325 is merged (probably 2025.10), all of its contents should be included in this PR
Related PRs: