Add tool calling to the LLM base class, implement in OpenAI #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhane
force-pushed
the
feature/llm-tool-invocation
branch
from
cd47dc2 to
882915f
Compare
oskarhane
commented
Apr 4, 2025
oskarhane
force-pushed
the
feature/llm-tool-invocation
branch
from
fc2f734 to
7f9bb39
Compare
stellasia
reviewed
Apr 4, 2025
| # Convert tools to OpenAI's expected type | ||
| openai_tools: List[ChatCompletionToolParam] = [] | ||
| for tool in tools: | ||
| openai_tools.append(cast(ChatCompletionToolParam, tool)) |
There was a problem hiding this comment.
Can't we create the object with ChatCompletionToolParam(**tool) (or something similar)?
There was a problem hiding this comment.
These are mypy related as well.
There was a problem hiding this comment.
Yes I guess this is because openai_tools is declared to be List[ChatCompletionToolParam] but tool is a dict. That's why I thought instantiating the ChatCompletionToolParam could fix mypy without having to use cast, but I don't know the model exactly so maybe it doesn't work.
| **params, | ||
| ) | ||
|
|
||
| message = response.choices[0].message |
There was a problem hiding this comment.
Not for now because this is also the case in the already existing methods, but we should probably try to reduce code duplication between the sync and async calls.
oskarhane
force-pushed
the
feature/llm-tool-invocation
branch
from
913c8be to
b769242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Complexity
Complexity: Medium
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):