Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve snippets #5282

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

Improve snippets #5282

wants to merge 22 commits into from

Conversation

chemzqm
Copy link
Member

@chemzqm chemzqm commented Mar 15, 2025

  • Insert nested snippets instead of merge snippet.
  • Different python snippet use its own global values as expected.
  • Accept all acceptable changes (not only the one change, one marker), unless the change affects snippet and other code.
  • Avoid execute python when current session have snippet using python.

@fannheyward
Copy link
Member

SnippetTextEdit is added in LSP 3.18, we also need to support this https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#snippetTextEdit

@chemzqm
Copy link
Member Author

chemzqm commented Mar 16, 2025

SnippetTextEdit is added in LSP 3.18, we also need to support this https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#snippetTextEdit

Need some work to allow snippet added to none active buffer.
What should happen when multiple snippets added to the same file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants