FEATURE: Introduce RoleId and RoleIds value objects

[bwaidelich]

Resolves: #3414

[kitsunet]

Suggested change

	public static function fromRoleId(RoleId $id, array $parentRoles = [], string $label = '', string $description = ''): self
	{
	return new ($id->value, array $parentRoles = [], string $label = '', string $description = '');
	}
	public static function fromIdentifierString(string $identifier, array $parentRoles = [], string $label = '', string $description = ''): self
	{
	return new ($identifier, array $parentRoles = [], string $label = '', string $description = '');
	}

And then deprecate the __construct as it is so we can at least open a window for refactoring internally?

[bwaidelich]

@kitsunet mh, Role::fromRoleId() and Role::fromIdentifierString() sounds wrong to me.. But what do you think of

public function __construct(RoleId|string $id, array $parentRoles = [], string $label = '', string $description = '') {
  if (is_string($id)) {
    $id = RoleId::fromString($id);
  }
  // ...
}

[kitsunet]

Sure, sounds good! My thought train was not finished really. I was thinking / hoping how we can refactor towards something like RoleIds $parentRoles or somthing, but the static constructors would not necessarily make that easier :D

[bwaidelich]

I agree – there is a lot of potential to improve things, but I wanted to avoid another rabbit hole (like #3410)
Adjusted with 32bbd2d

[kitsunet]

Yeah, totally fair