TASK: Cosmetic followup for #3443 #3447
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
we don't make a distinction inside the service from development, testing or production
after reflecting each class we sort classReflectionData which can also not be done instead :D but we still ensure that getAllClassNames returns all classes sorted. For using `array_diff` to get the $newClassNames we dont need sorting
kitsunet
approved these changes
Feb 14, 2025
|
|
||
| $propertyNames = []; | ||
| foreach ($this->classReflectionData[$className][self::DATA_CLASS_PROPERTIES] as $propertyName => $propertyData) { | ||
| foreach ($this->classReflectionData[$className][self::DATA_CLASS_PROPERTIES] ?? [] as $propertyName => $propertyData) { |
There was a problem hiding this comment.
Oh god, that is so much harder to read though, I wouldn't change that, shorter is not always better
There was a problem hiding this comment.
I'd say this combines short code with readability:
Suggested change
| foreach ($this->classReflectionData[$className][self::DATA_CLASS_PROPERTIES] ?? [] as $propertyName => $propertyData) { | |
| $classProperties = $this->classReflectionData[$className][self::DATA_CLASS_PROPERTIES] ?? [] | |
| foreach ($classProperties as $propertyName => $propertyData) { |
kdambekalns
reviewed
Feb 14, 2025
|
|
||
| return array_keys($this->classReflectionData); | ||
| $classNames = array_keys($this->classReflectionData); | ||
| sort($classNames); |
There was a problem hiding this comment.
Why the sorting? Is that the central replacement for the removed sort calls later on?
|
|
||
| $propertyNames = []; | ||
| foreach ($this->classReflectionData[$className][self::DATA_CLASS_PROPERTIES] as $propertyName => $propertyData) { | ||
| foreach ($this->classReflectionData[$className][self::DATA_CLASS_PROPERTIES] ?? [] as $propertyName => $propertyData) { |
There was a problem hiding this comment.
I'd say this combines short code with readability:
Suggested change
| foreach ($this->classReflectionData[$className][self::DATA_CLASS_PROPERTIES] ?? [] as $propertyName => $propertyData) { | |
| $classProperties = $this->classReflectionData[$className][self::DATA_CLASS_PROPERTIES] ?? [] | |
| foreach ($classProperties as $propertyName => $propertyData) { |
kdambekalns
requested changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the review of #3443 I couldn't help to do a little cleaning myself :D 🧹
Checklist
The PR is created against the lowest maintained branchFEATURE|TASK|BUGFIXReviewer - Breaking Changes are marked with!!!and have upgrade-instructions