-
-
Notifications
You must be signed in to change notification settings - Fork 227
BUGFIX: 4915 fusion ParsePartials
cache not flushed for symlinked packages
#4916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: 4915 fusion ParsePartials
cache not flushed for symlinked packages
#4916
Conversation
After discussing this extensively with @kitsunet (thanks 🙏 ) we are sure that this is the right direction for now. The challenges were mainly that the |
// should not happen as we ignored deleted files beforehand. | ||
throw new \RuntimeException("Couldn't resolve realpath for: '$changedFile'", 1709122619); | ||
} | ||
$identifiersToFlush[] = $this->getCacheIdentifierForAbsoluteUnixStyleFilePathWithoutDirectoryTraversal($fusionFileRealPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before #4838 the realpath
call would always happen inside this ParserCacheIdentifierTrait
method. The "revert" ist that we call realpath
again, but explicitly above, so its more obvious who and what and why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a local project
Resolves #4915
By reverting fix #4838
Which will lead to the original problem to resurface #4415 (but silently this time, no one will notice the cache flodding :D)
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions