BUGFIX: Fix and test tethered node structure adjustment #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently fails with
this is due to the blocking in |
mhsdesign
commented
Mar 31, 2024
| break; | ||
| } | ||
| /** @var Node $childNodeSource Node aggregates are never empty */ | ||
| $occupiedDimensionSpacePoints = $childNodeAggregate->occupiedDimensionSpacePoints->getPoints(); |
There was a problem hiding this comment.
idk if we should guard here with this check ... the added tests will pass either way ;)
if (count($occupiedDimensionSpacePoints) !== 1) {
throw new \RuntimeException('TODO: The ChildNodeAggregate occupies multiple origins.', 1711897662);
}
There was a problem hiding this comment.
I don't see an issue with the child node aggregate occupying multiple DSPs, that's totally legit
This was referenced Apr 2, 2024
mhsdesign
changed the title
nezaniel
reviewed
Apr 27, 2024
| break; | ||
| } | ||
| /** @var Node $childNodeSource Node aggregates are never empty */ | ||
| $occupiedDimensionSpacePoints = $childNodeAggregate->occupiedDimensionSpacePoints->getPoints(); |
There was a problem hiding this comment.
I don't see an issue with the child node aggregate occupying multiple DSPs, that's totally legit
|
✅ |
mhsdesign
commented
Apr 27, 2024
Neos.ContentRepository.Core/Classes/EventStore/EventsToPublish.php
Outdated
Show resolved
Hide resolved
bwaidelich
reviewed
Apr 27, 2024
Neos.ContentRepository.Core/Classes/EventStore/EventsToPublish.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.StructureAdjustment/src/StructureAdjustmentService.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.Core/Classes/EventStore/EventsToPublish.php
Outdated
Show resolved
Hide resolved
mhsdesign
force-pushed
the
task/writeTestForTetheredNodeStructureAdjustment
branch
from
1e97147 to
07f429a
Compare
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Jan 26, 2025
…events Applies suggestion originally posted in neos#4969 (comment) the resulting event log would be similar to: | event | correlation id | metadata | |---------------------------------|----------------|--------------------------------------------------------------------------------------------------------------------------------------------| | NodeAggregateWithNodeWasCreated | 123456 | `{structureAdjustment: 'Content Stream: %s; Dimension Space Point: %s, Node Aggregate: %s --- The tethered child node "bar" is missing.'}` | | NodePropertiesWereSet | 123456 | |
…eAggregate ... The behavior should be fully equivalent
mhsdesign
force-pushed
the
task/writeTestForTetheredNodeStructureAdjustment
branch
from
07f429a to
c0e759a
Compare
see `peerSucceedingSiblings` change
mhsdesign
force-pushed
the
task/writeTestForTetheredNodeStructureAdjustment
branch
from
c0e759a to
554a95e
Compare
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Jan 27, 2025
…events Applies suggestion originally posted in neos#4969 (comment) the resulting event log would be similar to: | event | correlation id | metadata | |---------------------------------|----------------|--------------------------------------------------------------------------------------------------------------------------------------------| | NodeAggregateWithNodeWasCreated | 123456 | `{structureAdjustment: 'Content Stream: %s; Dimension Space Point: %s, Node Aggregate: %s --- The tethered child node "bar" is missing.'}` | | NodePropertiesWereSet | 123456 | |
6 tasks
neos-bot
pushed a commit
to neos/contentrepository-structureadjustment
that referenced
this pull request
Jan 28, 2025
…events Applies suggestion originally posted in neos/neos-development-collection#4969 (comment) the resulting event log would be similar to: | event | correlation id | metadata | |---------------------------------|----------------|--------------------------------------------------------------------------------------------------------------------------------------------| | NodeAggregateWithNodeWasCreated | 123456 | `{structureAdjustment: 'Content Stream: %s; Dimension Space Point: %s, Node Aggregate: %s --- The tethered child node "bar" is missing.'}` | | NodePropertiesWereSet | 123456 | |
nezaniel
approved these changes
Feb 20, 2025
mhsdesign
deleted the
task/writeTestForTetheredNodeStructureAdjustment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that this line
neos-development-collection/Neos.ContentRepository.Core/Classes/Feature/Common/TetheredNodeInternals.php
Line 128 in 1fcdec4
This pr also adds causation ids and meta data for changes made by structure adjustments to easier debug them. See also #3887-> Moved to a dedicated pr in #5451Related: #4966
Related: #4832 (comment)
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions