-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: 4909 fusion plugins and tests #5304
BUGFIX: 4909 fusion plugins and tests #5304
Conversation
method renderResponse was renamed to renderEntryPathWithContext
> Could not resolve a route and its corresponding URI for the given parameters.
33eda04
to
bfc07b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the PHP in the behat but I don't think it warrants blocking stuff. We can refactor the tests any time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally fine by 👀 ... would remove the magic renaming of the ActionController class and use the real name.
…meActionController`
Resolves: #4909
Based on #5305 introduces a step to declare a flow controller in behat:
This comes with good and bad things.
The good thing is that the test is self contained and i have seen behat for example see also use that they create virtual php to test if the frame-work works.
Now the downside is that because of php there can only be ONE
MyPluginWithFusionController
across all tests declared which are executed in the same run. But for now this is not a problem as there are only two such fakes.Another problem is that we need some hacks (see
BehatRuntimeActionController
) to actually make this work.At first i attempted to have the files also separated in another location in (Test/Functional) of Neos.Neos but aside from them being spread around the whole planed i had problems with the proxybuilding there too.
But i believe that we do want to use behat to write self contained tests even if its hard right now but flow has to adjust at some point to this needs hopefully ^^.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions