Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Replace node identity converter aspect with NeosRouteValueNormalizer #5472

Merged

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Feb 20, 2025

Resolves: #5069

Depends on neos/flow-development-collection#3450 to introduce a RouteValuesNormalizerInterface

Re introduces Neos 8.3 magic to allow passing Node instances as route arguments:

fusion

uri = Neos.Fusion:ActionUri {
    action = 'someThing'
    arguments {
        node = ${node}
    }
}

php

$uriBuilder->uriFor(
    'someThing',
    ['node' => $node]
);

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign marked this pull request as ready for review February 20, 2025 15:24
@mhsdesign mhsdesign changed the title Bugfix: 5069 fix node identity converter aspect BUGFIX: Replace node identity converter aspect with NeosRouteValueNormalizer Feb 20, 2025
@mhsdesign mhsdesign requested a review from kitsunet February 20, 2025 15:31
… instances

This was a feature of Neos 8.3 - note that the current draft does not work e2e as for example the previewAction declares string $node and will crash with the __contextPath
@mhsdesign mhsdesign force-pushed the bugfix/5069-fix-NodeIdentityConverterAspect branch from 37ac463 to 73182a4 Compare February 20, 2025 16:52
… route values

neos/flow-development-collection#3450 introduces a new internal extension point which can now be used instead of AOP

It also allows us to not have to work with arrays like `__contextNodePath => ...` but encode the node first level so action controller specifying `string $node` work
@mhsdesign mhsdesign force-pushed the bugfix/5069-fix-NodeIdentityConverterAspect branch from 73182a4 to 14fa5cc Compare February 21, 2025 14:17
@mhsdesign mhsdesign merged commit d5ecff0 into neos:9.0 Feb 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate/Fix/Rethink NodeIdentityConverterAspect for 9.0
2 participants