Skip to content

Commit

Permalink
TASK: remove weird currentlyEditedPropertyNameIntermediate logic. The…
Browse files Browse the repository at this point in the history
… position of the switcher will soon change anyways
  • Loading branch information
dimaip committed Dec 15, 2018
1 parent 820361f commit 53c895e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
6 changes: 0 additions & 6 deletions packages/neos-ui-redux-store/src/CR/Nodes/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -398,12 +398,6 @@ export const subReducer = (state: State = defaultState, action: InitAction | Act
draft.focused.contextPath = contextPath;
draft.focused.fusionPath = fusionPath;
break;
// TODO: fix this code
// Set currentlyEditedPropertyName to currentlyEditedPropertyNameIntermediate and clear out currentlyEditedPropertyNameIntermediate
// This is needed because SET_CURRENTLY_EDITED_PROPERTY_NAME if fired before SET_FOCUS, but we still want to clear out currentlyEditedPropertyName
// when SET_FOCUS is triggered not from inline
// globalState.ui.contentCanvas.currentlyEditedPropertyName = globalState.ui.contentCanvas.currentlyEditedPropertyNameIntermediate;
// globalState.ui.contentCanvas.currentlyEditedPropertyNameIntermediate = '';
}
case actionTypes.UNFOCUS: {
draft.focused.contextPath = null;
Expand Down
2 changes: 0 additions & 2 deletions packages/neos-ui-redux-store/src/UI/ContentCanvas/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,6 @@ export const reducer = handleActions({
[FORMATTING_UNDER_CURSOR]: ({formatting}) => $set('ui.contentCanvas.formattingUnderCursor', new Map(formatting)),
[SET_CURRENTLY_EDITED_PROPERTY_NAME]: ({propertyName}) => $all(
$set('ui.contentCanvas.currentlyEditedPropertyName', propertyName),
// See SET_FOCUS why it's needed
$set('ui.contentCanvas.currentlyEditedPropertyNameIntermediate', propertyName)
),
[STOP_LOADING]: () => $set('ui.contentCanvas.isLoading', false),
[START_LOADING]: () => $set('ui.contentCanvas.isLoading', true),
Expand Down

0 comments on commit 53c895e

Please sign in to comment.