-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Allow grouping in DimensionSwitcher #3670
FEATURE: Allow grouping in DimensionSwitcher #3670
Conversation
As it is a feature we need to target Neos 9.0 here, or we need to discuss a potential 8.4 version. Did talk about that already at the hamburg sprint. But ATM it would target 9.0. Like the feature, btw. ;) |
I wasn't sure which version to target, but we need it in Neos 8.x for a customer 🙈 8.4 would make sense as well as upgrading to 9.x would be a big step for most afaik. |
@markusguenther hey, we need this for a customer on 8.3 which we won't update too soon. So it would be really good to have this landing on an 8.x branch, as otherwise we need to patch forever... and I think the feature has little risk :) All the best, Sebastian |
By the way, I wrote a short proposal on Discuss to getting the feature out the door without tricking SemVer. |
a575e47
to
dcc2a45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice improvement. The failing end-to-end test is also broken in the 8.3 and 8.4 branches. For some reason in 8.2 and 9.0 it works and locally it works also.
dcc2a45
to
97eaf40
Compare
Ok, acceptance tests now also work :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by reading
What I did
If (and only if) a
Neos.ContentRepository.contentDimensions.[...].presets
preset contains agroup
then theDimensionSwitcher
dropdown is grouped.Example:
How I did it
I additionally map the
group
field when transforming language presets to select box options.How to verify it
Wrote a test for it.
Add groups to language presets and open the DimensionSwitcher.