TASK: Optimize cloning in update-neos-ui-compiled.sh #3920
Conversation
The script clones `[email protected]:neos/neos-ui-compiled.git` – and that is a **massive** repository. Cloning it uses a lot of space (over 1 GB) and takes long, as the Jenkins log shows (timestamps are elapsed time): ``` 00:00:50.125 + git clone [email protected]:neos/neos-ui-compiled.git tmp_compiled_pkg 00:00:50.137 Cloning into 'tmp_compiled_pkg'... 00:21:54.271 + cd tmp_compiled_pkg 00:21:54.272 + git checkout origin/8.4 ``` That took… more than 20 minutes! Yikes! I suggest to do this instead: ``` git clone --depth 1 [email protected]:neos/neos-ui-compiled.git --single-branch --branch=${BRANCH} tmp_compiled_pkg ``` Takes about 10 seconds for me, transfers around 5 MB of data, uses 23 MB of disk space and even saves us the `git checkout`, as the branch is already taken care of.
|
"Fun" fact: All our Neos checkouts on Jenkins (as they prefer source checkouts) have a 1 GB Neos.Neos.Ui.Compiled package… 😑 Too bad we cannot seem to change that, as the dev versions can only be checked out "from cache" via Composer, even overriding the See also composer/composer#10074 (comment) |
|
New issue with Composer: composer/composer#12310 🤞 |
There was a problem hiding this comment.
Thank you for noticing this and fixing it ;)
This definitely goes into the direction of #3367 -> through our .yarn cache folder the repo just grows quite fast ... we might need to promote similar ways to checkout also for developers so they save diskspace. Maybe in case we still want to merge the Neos Ui repo into Neos.Neos we can avoid these heavy artifacts to be merged.
kdambekalns
deleted the
task/optimize-update-neos-ui-compiled-cloning
branch
The script clones
[email protected]:neos/neos-ui-compiled.git– and that is a massive repository. Cloning it uses a lot of space (over 1 GB) and takes long, as the Jenkins log shows (timestamps are elapsed time):That took… more than 20 minutes! Yikes!
I suggest to do this instead:
Takes about 10 seconds for me, transfers around 5 MB of data, uses 23 MB of disk space and even saves us the
git checkout, as the branch is already taken care of.