refactor: use vim._with where possible
#29244
Conversation
github-actions
bot
added
lsp
treesitter
diagnostic
filetype
dundargoc
removed
lsp
treesitter
diagnostic
filetype
dundargoc
force-pushed
the
refactor/with
branch
2 times, most recently
from
a969bc7
to
e811ce4
Compare
dundargoc
changed the title
vim._with everywherevim._with where possible
|
This mostly means replacing `nvim_buf_call` and `nvim_win_call` with `vim._with`.
| vim.cmd [[set isfname+=@-@]] | ||
| local url = vim.fn.expand('<cfile>') | ||
| vim.o.isfname = old_isfname | ||
| local url = vim._with({ o = { isfname = vim.o.isfname .. ',@-@' } }, function() |
There was a problem hiding this comment.
I'd recommend using more targeted scopes for options. As isfname is global option, I'd use go instead of o.
It seems to make code more explicit while avoiding extra step in implementation that decided which scope should be used.
There was a problem hiding this comment.
I don't think that's more correct. If isfname becomes global-local in the future, won't vim.go be incorrect (since we're changing the default/global value rather than the value of the buffer)?
There was a problem hiding this comment.
If 'isfname' scopes are changed, then using bo or wo here will be better. Right now this option is sensible to be used with go, as its scope is global. Using o as scope here will only lead to more work done during this function execution with the same result as go.
That said, It is not particularly strong opinion per se.
This mostly means replacing
nvim_buf_callandnvim_win_callwithvim._with.