fix: screenchar works when multigrid enabled #29316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfredl
reviewed
Jun 14, 2024
| @@ -803,6 +803,7 @@ void ui_ext_win_position(win_T *wp, bool validate) | |||
| if (!wp->w_floating) { | |||
| ui_call_win_pos(wp->w_grid_alloc.handle, wp->handle, wp->w_winrow, | |||
| wp->w_wincol, wp->w_width, wp->w_height); | |||
| ui_put_grid(&wp->w_grid_alloc, false); | |||
There was a problem hiding this comment.
I don't think this should be done. in multigrid mode, there is no guarantee that the grid size of the specific windows will match the space in default_grid (that's the entire point of ext_multigrid mode), so things will get weird in other ways. Also it breaks an abstraction boundary to ui_compositor.c which is not something I like for a edge case unrelated to ordinary use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #29135